[WIP]4987+4988: Angular select class implementation and refactoring tests #5096

b14ckster · 2023-10-13T15:11:33Z

No description provided.

pnatashap · 2023-10-13T17:00:23Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/Select.java

+
+public class Select extends UIBaseElement<SelectAssert> implements HasPlaceholder, IClickable {
+
+    @JDIAction


JDIAction должны быть с текстовым описанием

pnatashap · 2023-10-13T17:01:04Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/Select.java

+
+    @JDIAction
+    public void expand() {
+        click();


а если элемент уже открыт, то клик по нему приведет не к открытию

pnatashap · 2023-10-13T17:01:44Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/Select.java

+
+    @JDIAction
+    public String role() {
+        return core().getAttribute("name");


дублирует предыдущий

pnatashap · 2023-10-13T17:03:34Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/Select.java

+
+    @JDIAction
+    public String name() {
+        return core().getAttribute("name");


какой смысл проверять name?

pnatashap · 2023-10-13T17:05:50Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/Select.java

+    }
+
+    @Override
+    public void click() {


а зачем переопределение в таком виде? так и будет работать

pnatashap · 2023-12-10T01:48:05Z

...ight-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/MaterialSelector.java

+    }
+
+    @JDIAction("Is '{name}' disabled")
+    public boolean disabled() {


Condition is different

Enabled should be overrided

pnatashap · 2023-12-10T01:48:29Z

...ight-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/MaterialSelector.java

    }

    protected UIElement toggle() {
        return new UIElement(By.xpath(format(toggle,
                                                    this.core().locator.printLocator().replace(smartSharp, "")
                                                            .replace(cssSharp, "").replace("'", ""))));
    }
+
+    @JDIAction("Get '{name}' name")
+    public String name() {


We do not need this method

pnatashap · 2023-12-10T01:53:13Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/SelectAssert.java

+import static org.hamcrest.Matchers.hasItem;
+import static org.hamcrest.Matchers.hasItems;
+
+public class SelectAssert extends UIAssert<SelectAssert, MaterialSelector> {


Suggested change

public class SelectAssert extends UIAssert<SelectAssert, MaterialSelector> {

public class MaterialSelectAssert extends UIAssert<MaterialSelectAssert, MaterialSelector> {

pnatashap · 2023-12-10T01:55:48Z

jdi-light-angular/src/main/java/com/epam/jdi/light/angular/asserts/SelectAssert.java

+        return selected(getEnumValue(option));
+    }
+
+    public <T extends Enum<?>> SelectAssert value(final T option) {


It is near to impossible to guess that value means that there is an option with this value, it should be selected value

pnatashap · 2023-12-10T02:13:18Z

...ight-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/MaterialSelector.java

-public class MaterialSelector extends UIBaseElement<MaterialSelectorAssert> implements HasLabel {
-    public String toggle = "//*[@id='%s']//div[contains(@class,'mat-select-arrow')][not(contains(@class, 'wrapper'))]";
+public class MaterialSelector extends UIBaseElement<SelectAssert> implements HasLabel {
+    public String toggle = "//*[@id='%s']//div[contains(@class,'mat-mdc-select-arrow')][not(contains(@class, 'wrapper'))]";


Locators should be much more simple, without id and other things

pnatashap · 2023-12-10T02:42:21Z

...r/src/main/java/com/epam/jdi/light/angular/elements/composite/MaterialSelectorContainer.java

+    public void multipleSelect(int... indexes) {
+        WebList options = getOptions();
+        for (int index : indexes) {
+            options.get(index).click();


If the value is already selected, click will unselect it

pnatashap · 2023-12-10T02:42:36Z

...r/src/main/java/com/epam/jdi/light/angular/elements/composite/MaterialSelectorContainer.java

+    public void multipleSelect(String... values) {
+        WebList options = getOptions();
+        for (String str : values) {
+            options.get(str).click();


If the value is already selected, click will unselect it

pnatashap · 2023-12-10T02:42:42Z

...r/src/main/java/com/epam/jdi/light/angular/elements/composite/MaterialSelectorContainer.java

+    @JDIAction("Select '{0}' in '{name}'")
+    public void select(int index) {
+        WebList options = getOptions();
+        options.get(index).click();


If the value is already selected, click will unselect it

pnatashap · 2023-12-10T02:42:49Z

...r/src/main/java/com/epam/jdi/light/angular/elements/composite/MaterialSelectorContainer.java

+    public void select(String value) {
+        if (value == null) return;
+        WebList options = getOptions();
+        options.get(value).click();


If the value is already selected, click will unselect it

pnatashap · 2023-12-10T02:44:07Z

...ight-angular/src/main/java/com/epam/jdi/light/angular/elements/complex/MaterialSelector.java

-public class MaterialSelector extends UIBaseElement<MaterialSelectorAssert> implements HasLabel {
-    public String toggle = "//*[@id='%s']//div[contains(@class,'mat-select-arrow')][not(contains(@class, 'wrapper'))]";
+public class MaterialSelector extends UIBaseElement<SelectAssert> implements HasLabel {
+    public String toggle = "//*[@id='%s']//div[contains(@class,'mat-mdc-select-arrow')][not(contains(@class, 'wrapper'))]";
    public String hintLocator = "//*[@id='%s']/ancestor::mat-form-field//mat-hint";
    public String errorLocator = "//*[@id='%s']/ancestor::mat-form-field//mat-error";
    public String smart = "smart: ";


dropdown id not need to get selected value

b14ckster added Angular Refactoring code refactoring ReWork labels Oct 13, 2023

This was linked to issues Oct 13, 2023

Create class implementing angular element Select #4987

Open

Tests refactoring: select element #4988

Open

pnatashap requested changes Oct 13, 2023

View reviewed changes

MayaElf requested a review from vklonin October 18, 2023 11:14

MayaElf self-assigned this Oct 18, 2023

MayaElf changed the title ~~4987+4988: Angular select class implementation and refactoring tests~~ [WIP]4987+4988: Angular select class implementation and refactoring tests Oct 18, 2023

MayaElf force-pushed the angular_select_implementation branch from 7e0a70f to 5535a81 Compare October 18, 2023 12:39

MayaElf removed their assignment Nov 9, 2023

kmikheeva self-assigned this Nov 14, 2023

b14ckster and others added 4 commits November 22, 2023 17:34

first methods for select implementation

3d4652b

4987-88-refactoringSelectMoveToNewPage

7a978e3

4988-refactoringSelectDeleteDuplicates

30bd774

4988-refactoringSelect3tests

e099e7c

kmikheeva force-pushed the angular_select_implementation branch from 3ad2d56 to e099e7c Compare November 22, 2023 13:45

pnatashap requested changes Dec 10, 2023

View reviewed changes

igor-vlasiuk self-assigned this Dec 18, 2023

Kate-Semenova mentioned this pull request Jan 31, 2024

#4926: Tests refactoring: Paginator element #5386

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP]4987+4988: Angular select class implementation and refactoring tests #5096

[WIP]4987+4988: Angular select class implementation and refactoring tests #5096

b14ckster commented Oct 13, 2023

pnatashap Oct 13, 2023

pnatashap Oct 13, 2023

pnatashap Oct 13, 2023

pnatashap Oct 13, 2023

pnatashap Oct 13, 2023

pnatashap Dec 10, 2023

pnatashap Dec 10, 2023

pnatashap Dec 10, 2023

pnatashap Dec 10, 2023

pnatashap Dec 10, 2023

pnatashap Dec 10, 2023

pnatashap Dec 10, 2023

pnatashap Dec 10, 2023

pnatashap Dec 10, 2023

pnatashap Dec 10, 2023


		public class Select extends UIBaseElement<SelectAssert> implements HasPlaceholder, IClickable {

		@JDIAction

	public class SelectAssert extends UIAssert<SelectAssert, MaterialSelector> {
	public class MaterialSelectAssert extends UIAssert<MaterialSelectAssert, MaterialSelector> {

[WIP]4987+4988: Angular select class implementation and refactoring tests #5096

Are you sure you want to change the base?

[WIP]4987+4988: Angular select class implementation and refactoring tests #5096

Conversation

b14ckster commented Oct 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment