Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling QPI counters #111

Comments

Copy link

This code freezes, enables, resets, and unfreezes the QPI PMON registers:
https://github.com/opcm/pcm/blob/bce551dfcdc5fb8360c3ca7acf17b4a5c6c32a13/cpucounters.cpp#L4729-L4766

However, I could not find anywhere in the code were those counters are disabled, i.e. it's not in cleanupPMU nor in resetPMU.

I have also verified that if I launch pcm.x once, then disable the above code, then relaunch pcm.x, then the QPI bandwidth is still reported correctly, proof that the counters were still active.

I don't know if I this has any impact on performance, or if there is a simple way to disable the counters; but it would be useful to add this to the API. For now I'll bake my own script with setpci for this purpose.

@opcm
Copy link
Contributor

opcm commented Jan 16, 2019

there is no impact on performance. The cleanup for uncore PMUs will be implemented soon.

rdementi added a commit that referenced this issue Jan 31, 2019
adresses #111

Change-Id: I8ccea31edf1b4b6ec36206e0bab370a2ec629ad7
@opcm
Copy link
Contributor

opcm commented Feb 6, 2019

this is addressed in the master branch.

@opcm opcm closed this as completed Feb 6, 2019
rdementi added a commit that referenced this issue Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants