Wordsmith the TLS secure close depiction #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLS requires that you send an alert (whether error or "close_notify") before closing the write side of your connection, but not to wait around to receive the one from the peer. Use wording a bit stronger than "provides a facility for" to try to align more closely with the protocol requirements.
royfielding
approved these changes
Sep 9, 2021
mnot
approved these changes
Sep 10, 2021
Section references are good. Co-authored-by: Martin Thomson <[email protected]>
royfielding
approved these changes
Sep 10, 2021
reschke
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by my ballot comments (#915 )
I started trying to write something about how it's required to send "close_notify" in normal connection shutdown, but didn't like how that worked, and ended up here.
I am not sure if I regressed in some other axes while improving on this one, though.