Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

415 and Accept #48

Closed
martinthomson opened this issue Mar 5, 2018 · 13 comments
Closed

415 and Accept #48

martinthomson opened this issue Mar 5, 2018 · 13 comments
Assignees

Comments

@martinthomson
Copy link
Contributor

This came up in ACME where they wanted to use 415 and Accept.

RFC 7694 implies this is OK, and makes two observations:

  • 415 is for cases where request content type or content coding is not acceptable
  • you can use Accept-Encoding with 415

RFC 7694 failed to explicitly allow Accept with 415, though it naturally follows.

We might consider rolling 7694 into any update given its tiny size, and then fix this in the process.

@reschke
Copy link
Contributor

reschke commented Mar 15, 2018

Allowing "Allow" "Accept" sounds right to me.

Whether we want to make this in scope of http11ter we'll need to discuss...

@reschke
Copy link
Contributor

reschke commented Jul 5, 2018

Opened #119 to discuss inclusion of RFC 7694.

If we decide not to do this, should we update 7694 instead?

@mnot
Copy link
Member

mnot commented Jul 11, 2018

@reschke I think you mean "Accept" above, not "Allow", correct?

@reschke
Copy link
Contributor

reschke commented Jul 11, 2018

Right.

@mnot
Copy link
Member

mnot commented Jul 18, 2018

Discussed in Montreal; some support for doing this, but take it to the list.

@mnot mnot removed the discuss label Nov 6, 2018
@reschke
Copy link
Contributor

reschke commented Mar 25, 2019

@martinthomson - what was the outcome on the ACME side?

@martinthomson
Copy link
Contributor Author

I think that they avoided it:

If a request does not meet this requirement, then the server MUST return a response with status code 415 (Unsupported Media Type).

With no mention of Accept. I don't know what Boulder does, but can probably find out if absolutely necessary.

@reschke
Copy link
Contributor

reschke commented Jul 26, 2019

@martinthomson - that would be great.

@jsha
Copy link

jsha commented Jul 26, 2019

In Boulder, if a POST doesn't have Content-Type: application/json, we return 415 with no Accept header.

@spaceone
Copy link

spaceone commented Aug 2, 2019

I don't understand the initial issue here fully but it would be nice If HTTP would have something to indicate in a response which response payloads it provides, e.g. using Accept: application/json; q=1.0, text/html; q=0.9 in a response (e.g. to a OPTIONS request)!

And what also would be nice is if the resource could also inform the client which media types it supports in the request (as JSON has no forms to include this information and HTML only allows forms with application/x-www-form-urlencoded and multipart/form-data there is no standardized way to tell clients the possibilities).

@mnot
Copy link
Member

mnot commented Feb 2, 2020

Discussed in Basel; ACME apparently doesn't need this any more. Waiting on resolution of #119.

@mnot mnot added the waiting label Feb 2, 2020
@mnot mnot removed the waiting label May 25, 2020
@mnot
Copy link
Member

mnot commented May 25, 2020

@reschke do you wan to take this one?

@reschke
Copy link
Contributor

reschke commented May 25, 2020

I can give it a try.

@reschke reschke self-assigned this May 25, 2020
royfielding added a commit that referenced this issue Jul 1, 2020
Allow "Accept" in response messages (#48)
@mnot mnot closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants