enable ConnectionString usage in pg client #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@halvardssm looks like the checks are passing. would you mind reviewing this? Thanks! (some context: I'm using |
|
Hi @twhitbeck ! Thanks for your PR! I have no problem with merging this change, but could you add the same type for the MySQL and SQLite clients as well? |
Looks like the MySQL client is fine as is. I applied the same approach to the SQLite client, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a breaking change?
Checklist:
Please review the
guidelines for contributing
to this repository.
When all of the above is completed, request a review from one of the codeowners.
Description:
Support all constructor parameter patterns of
deno-postgresclient.