Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies from base Volley package to toolbox package. #369

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Fix dependencies from base Volley package to toolbox package. #369

merged 1 commit into from
Sep 30, 2020

Conversation

jpd236
Copy link
Collaborator

@jpd236 jpd236 commented Sep 29, 2020

  • Move AsyncHttpStack usage from AsyncNetwork to BasicAsyncNetwork.
    This is consistent with Network/BasicNetwork's use of HttpStack.
  • Inline ThrowingCache inside AsyncRequestQueue, as no one else uses
    it, and it's not generally useful at this time.

@jpd236
Fix dependencies from base Volley package to toolbox package.
aa0512f 
-  Move AsyncHttpStack usage from AsyncNetwork to BasicAsyncNetwork.
   This is consistent with Network/BasicNetwork's use of HttpStack.
-  Inline ThrowingCache inside AsyncRequestQueue, as no one else uses
   it, and it's not generally useful at this time.
@jpd236 jpd236 requested a review from jbiral September 29, 2020 23:30
@jpd236 jpd236 merged commit 46a4f90 into google:master Sep 30, 2020
@jpd236 jpd236 deleted the toolbox-dep branch September 30, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiral jbiral jbiral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpd236 @jbiral