Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak Bug Fixes & Retry Enable/Disable in progress #183

Closed
wants to merge 2 commits into from

Conversation

way2jatin
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jpd236
Copy link
Collaborator

jpd236 commented May 15, 2018

The memory leak was already fixed in #114 - you should not observe it if you use a SNAPSHOT build of Volley, and we'll release the fix in upcoming version 1.1.1.

Otherwise, this change seems to consist of a parameter to HurlStack that, when set, calls setChunkedStreamingMode(0) when creating the HttpUrlConnection. I don't know what the value is of doing this in general - perhaps you could provide more details if you think this is truly something that other apps would benefit from. But if it's just for your own use case, I'd recommend you just extend HurlStack and override createConnection, and you can do whatever you want to the connection before returning it there. Then no change is needed to Volley.

Closing this out, but let me know if you still think there is something generally useful here. In the future, I'd recommend reaching out to [email protected] or filing a bug first before making a change - we can generally help advise on the right direction before you get to writing any code.

@jpd236 jpd236 closed this May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants