Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GACAppCheckTokenResult type #18

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Add GACAppCheckTokenResult type #18

merged 4 commits into from
Aug 30, 2023

Conversation

andrewheard
Copy link
Collaborator

Added a GACAppCheckTokenResult type that encapsulates an App Check Token and nullable error. This will replace id<GACAppCheckTokenProtocol> _Nullable token, NSError *_Nullable error in token fetching completion blocks in the public API.

@andrewheard andrewheard marked this pull request as ready for review August 29, 2023 23:27
@andrewheard andrewheard requested a review from ncooke3 August 29, 2023 23:27
#import "AppCheckCore/Sources/Public/AppCheckCore/GACAppCheckToken.h"

/// Placeholder value that indicates failure.
/// This value is `{"error":"UNKNOWN_ERROR"}` encoded as base64.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea mentioning what the value is decoded 👍

@andrewheard andrewheard merged commit f191868 into main Aug 30, 2023
@andrewheard andrewheard deleted the ah/token-result branch August 30, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants