Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use version for action azure/webapps-deploy instead of hash #25781

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Use version for action azure/webapps-deploy instead of hash #25781

merged 4 commits into from
Jun 5, 2023

Conversation

samuel-coderhead
Copy link
Contributor

@samuel-coderhead samuel-coderhead commented Jun 1, 2023 •
edited by cmwilson21
Loading

Why:

When changing to version instead of specific commit the action runs as expected.

Closes: #25780

What's being changed (if available, include any code snippets, screenshots, or gifs):

Remove specific commit and use version instead.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Jun 1, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/deployment/deploying-to-your-cloud-provider/deploying-to-azure/deploying-docker-to-azure-app-service.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
actions/deployment/deploying-to-your-cloud-provider/deploying-to-azure/deploying-java-to-azure-app-service.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
actions/deployment/deploying-to-your-cloud-provider/deploying-to-azure/deploying-net-to-azure-app-service.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
actions/deployment/deploying-to-your-cloud-provider/deploying-to-azure/deploying-nodejs-to-azure-app-service.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
actions/deployment/deploying-to-your-cloud-provider/deploying-to-azure/deploying-php-to-azure-app-service.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
actions/deployment/deploying-to-your-cloud-provider/deploying-to-azure/deploying-python-to-azure-app-service.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@samuel-coderhead samuel-coderhead marked this pull request as ready for review June 1, 2023 13:53
@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 1, 2023
@cmwilson21
Copy link
Contributor

@samuel-coderhead Thanks for submitting a PR! I've edited your post slightly to connect it to your issue.

I'll get this triaged for review! ⚡

skedwards88
skedwards88 reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! We require third party actions to use a SHA (https://github.com/github/docs-internal/blob/main/contributing/content-style-guide.md#pinning-version-numbers-to-sha), so I've updated your changes to use the SHA of the latest release (v2.2.9) instead. I'll incorporate those suggestions, then we'll get this merged for you.

...deploying-to-your-cloud-provider/deploying-to-azure/deploying-docker-to-azure-app-service.md Outdated Show resolved Hide resolved
...t/deploying-to-your-cloud-provider/deploying-to-azure/deploying-java-to-azure-app-service.md Outdated Show resolved Hide resolved
...nt/deploying-to-your-cloud-provider/deploying-to-azure/deploying-net-to-azure-app-service.md Outdated Show resolved Hide resolved
...deploying-to-your-cloud-provider/deploying-to-azure/deploying-nodejs-to-azure-app-service.md Outdated Show resolved Hide resolved
...nt/deploying-to-your-cloud-provider/deploying-to-azure/deploying-php-to-azure-app-service.md Outdated Show resolved Hide resolved
...deploying-to-your-cloud-provider/deploying-to-azure/deploying-python-to-azure-app-service.md Outdated Show resolved Hide resolved
@skedwards88 skedwards88 enabled auto-merge June 2, 2023 18:14
@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jun 2, 2023
@skedwards88 skedwards88 added this pull request to the merge queue Jun 5, 2023
Merged via the queue into github:main with commit 2ef6d16 Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command in guide Deploying Docker to Azure App Service no longer working
3 participants
@samuel-coderhead @cmwilson21 @skedwards88