Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend to use 127.0.0.1 instead of localhost #20967

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Recommend to use 127.0.0.1 instead of localhost #20967

merged 4 commits into from
Oct 12, 2022

Conversation

hickford
Copy link
Contributor

@hickford hickford commented Sep 28, 2022 •
edited
Loading

Why:

recommended by OAuth spec https://datatracker.ietf.org/doc/html/rfc8252#section-7.3

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 28, 2022
@hickford hickford marked this pull request as ready for review September 28, 2022 17:44
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
developers/apps/building-oauth-apps/authorizing-oauth-apps.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
 fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@Ahmadtaqwa58

This comment was marked as spam.

Sign in to view
@cmwilson21
Copy link
Contributor

@hickford Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review developers Content related to developers SME reviewed An SME has reviewed this issue/PR and removed triage Do not begin working on this issue until triaged by the team labels Sep 30, 2022
@cmwilson21
Copy link
Contributor

✍️ For the the future docs reviewer - I checked with an SME and we can suggest 127.0.0.1 for loopback on IPv4 but not on IPv6-only devices. See the link in my notes for more info.

@rachaelrenk rachaelrenk self-requested a review October 12, 2022 19:09
rachaelrenk
rachaelrenk approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@rachaelrenk rachaelrenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨ I made one small tweak to align with our style guide. Thank you for submitting this update! 🚀

@rachaelrenk rachaelrenk merged commit fea1891 into github:main Oct 12, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachaelrenk rachaelrenk rachaelrenk approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team developers Content related to developers SME reviewed An SME has reviewed this issue/PR waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hickford @Ahmadtaqwa58 @cmwilson21 @rachaelrenk