Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: extract explicit alias types #18283

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Dec 13, 2024

This is a rebased version of #17341. Some tests are giving unexpected results, so there may still be some bugs that I've introduced in rebasing.

mbg and others added 30 commits December 10, 2024 16:15
This makes it clearer when changes in test results
are due to changes in the standard library.
Read through as many aliases as possible before getting
the underlying type.
Use object like we do for named types.
smowton and others added 5 commits December 10, 2024 23:17
This means that there is a target for defs and refs to refer to after the original fields go away because their corresponding structs have also gone away on a database downgrade.
…exported methods defined in different packages
They are only used by private predicates. They can be made public in
future if needed.
@owen-mc owen-mc force-pushed the go/extract-alias-types branch from 1267d6a to 187b5ee Compare December 13, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants