Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bazel to 8.0.0. #18257

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Upgrade bazel to 8.0.0. #18257

merged 1 commit into from
Dec 11, 2024

Conversation

criemen
Copy link
Collaborator

@criemen criemen commented Dec 10, 2024

Previously, we were using 8.0.0rc1.
In particular, this upgrade means we need to explicitly import more rules, as they've been moved out of the core bazel repo.
I did all the work of importing rules_shell everywhere, and then discovered that rules_go still requires the autoload.
I kept the changes, as I believe they go in the right direction, and once bazel-contrib/rules_go#4193 has been fixed, we can switch over for good.

@github-actions github-actions bot added C# Python Go Rust Pull requests that update Rust code Swift Kotlin labels Dec 10, 2024
Previously, we were using 8.0.0rc1.
In particular, this upgrade means we need to explicitly
import more rules, as they've been moved out of the core bazel repo.
@criemen criemen marked this pull request as ready for review December 10, 2024 11:45
@criemen criemen requested review from a team as code owners December 10, 2024 11:45
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# LGTM

Copy link
Contributor

@igfoo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me

@criemen criemen merged commit f097168 into main Dec 11, 2024
52 checks passed
@criemen criemen deleted the criemen/bazel-8-00 branch December 11, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Go Kotlin Python Rust Pull requests that update Rust code Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants