Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased unit tests coverage #3691

Merged
merged 3 commits into from
Aug 12, 2023

Conversation

araujo88
Copy link
Contributor

@araujo88 araujo88 commented Aug 8, 2023

Increased unit tests coverage for response_writer.go and render/json.go.

@araujo88
Copy link
Contributor Author

There seems to be an issue with golangci-lint which is causing this and another PR to fail the checks.

@appleboy
Copy link
Member

Please rebase the branch.

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #3691 (9671275) into master (d16fdb1) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3691      +/-   ##
==========================================
+ Coverage   99.01%   99.20%   +0.19%     
==========================================
  Files          42       42              
  Lines        3157     3157              
==========================================
+ Hits         3126     3132       +6     
+ Misses         21       17       -4     
+ Partials       10        8       -2     
Flag Coverage Δ
99.20% <ø> (+0.19%) ⬆️
go-1.18 99.11% <ø> (+0.19%) ⬆️
go-1.19 99.20% <ø> (+0.19%) ⬆️
go-1.20 99.20% <ø> (+0.19%) ⬆️
macos-latest 99.20% <ø> (+0.19%) ⬆️
ubuntu-latest 99.20% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@appleboy appleboy added the test label Aug 12, 2023
@appleboy appleboy added this to the v1.10 milestone Aug 12, 2023
@appleboy appleboy merged commit bb2d8cf into gin-gonic:master Aug 12, 2023
@araujo88 araujo88 deleted the fix/increase-unit-test-coverage branch August 12, 2023 16:16
araujo88 added a commit to araujo88/gin that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants