Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vulkan surface capabilities being advertised when its query failed. #6510

Conversation

Wumpf
Copy link
Member

@Wumpf Nov 10, 2024

Connections
I'm sure there's related tickets, but it's hard to dig up :/

Description
Observed in the wild Vulkan adapter gets chosen despite the surface being not compatible (e.g. causing a Vulkan adapter to be chosen over a working GL adapter). This happend because Vulkan backend violated the contract of returning usable surface configs.

Extending GetSurfaceSupportError is somewhat unrelated. More of a desperate attempt to output more information.

Testing
I unfortunately don't have a repro case for any of these failures.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, good catch!

force-pushed the fix-vulkan-surface-cap-query branch from d1d1d38 to 4f39685 Compare November 12, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants