Upgrade to Jest 16 #858
Merged
Upgrade to Jest 16 #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also looks like Jest 16.0.1 will be cut soon with a bug fix, so I held off from doing a minor update to the package version for |
Closed
|
That's not the only issue but React 15.4.0 final will contain fixes for all major issues. We'll still need to add a traversal API but that would be the last missing bit and not essential. |
|
Should be good to go with 16.0.1 now. Should I bump the react-scripts version by a minor version or would it be a revision in this case? |
|
Don't worry about bumping |
|
Thanks! |
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
* Update react-scripts dependencies to use jest 16 * Remove testRegex from Jest config (now default)
jarlef
pushed a commit
to jarlef/create-react-app
that referenced
this pull request
Nov 28, 2016
* Update react-scripts dependencies to use jest 16 * Remove testRegex from Jest config (now default)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #851.
Looks like the only things requiring an update were
babel-jestandjestinreact-scripts.This should probably be another issue for later, but:
The only things that I wasn't certain on is how the updated Snapshot Testing capabilities should be handled. The README template considers them experimental, but there was a pretty huge emphasis on the magic of snapshots in the v16 blog post.
@gaearon Is the only thing currently blocking adoption this issue?
facebook/react#7371