Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to re-select way after dragging a node #771

Closed
mvexel opened this issue Jan 30, 2023 · 1 comment
Closed

Need to re-select way after dragging a node #771

mvexel opened this issue Jan 30, 2023 · 1 comment

Comments

@mvexel
Copy link
Contributor

mvexel commented Jan 30, 2023

Description

A common operation when modifying the geometry of a way is to drag multiple nodes in succession. In iD, you can do this without having to re-select the way after dragging a node. In Rapid, after dragging a node in a way, you need to re-select the way before you can drag another node, making this operation less efficient.

Version

2.00-alpha.3.3

What browser are you seeing the problem on? What version are you running?

Chrome v109.0

Steps to reproduce

  1. Select a way
  2. Drag a node

The browser URL at the time you encountered the bug

https://mapwith.ai/rapid-v2-alpha3#background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&map=21.58/40.78602/-111.92437
@bhousel
Copy link
Contributor

bhousel commented Jan 30, 2023

I agree - I had noticed this before and I thought this was covered by #760, but I guess they are a bit different.

bhousel added a commit that referenced this issue Oct 16, 2023
@bhousel
Better treatment of reselectIDs when dragging
c5b4c36 
(re: #771, #760)

This was addressed quickly in earlier commits, but I think this handles the issue
in a better way.

If the node being dragged has a parent that is already selected, then we preserve
the selection (lines or areas), otherwise we select the node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhousel @mvexel