Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-clicking on a way to add a node does not work. #652

Closed
Bonkles opened this issue Nov 15, 2022 · 2 comments
Closed

Double-clicking on a way to add a node does not work. #652

Bonkles opened this issue Nov 15, 2022 · 2 comments
Assignees
@Bonkles
Milestone
v2 Alpha 3

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Nov 15, 2022

No description provided.

@Bonkles Bonkles moved this from Triage to 🏗 In progress in RapiD v2 Release Board Nov 15, 2022
@Bonkles Bonkles mentioned this issue Nov 15, 2022
Closed
@Bonkles
Copy link
Contributor Author

Bonkles commented Nov 15, 2022

First impl committed in b039efe, but only the midpoint code seems to actually add the nodes and render them.

Bonkles added a commit that referenced this issue Nov 16, 2022
@Bonkles
Fix #652 by supplying the correct coord / lat-lng to the actionAddMid…
0b6551d 
…point call.
@Bonkles Bonkles self-assigned this Nov 16, 2022
@Bonkles Bonkles added this to the v2 Alpha 3 milestone Nov 16, 2022
@Bonkles
Copy link
Contributor Author

Bonkles commented Nov 16, 2022

Fixed the impl in 0b6551d9bcf296eed2110754752b5fcea84cd463. There was a bug in both the loc we were supplying to the actionAddMidpoint method and we were feeding geoChooseEdge a lat/lon, not a screen coord.

@Bonkles Bonkles closed this as completed Nov 16, 2022
@Bonkles Bonkles moved this from 🏗 In progress to 🔖 Pending Release in RapiD v2 Release Board Nov 16, 2022
@Bonkles Bonkles moved this to Pending Release in Rapid v2 Beta Board Nov 30, 2022
@Bonkles Bonkles moved this from Pending Release to Ready for QA ✅ in Rapid v2 Beta Board Dec 6, 2022
@Bonkles Bonkles moved this from Ready for QA ✅ to 🏁 Done in Rapid v2 Beta Board Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bonkles Bonkles

Labels
None yet
Projects
Rapid v2 Beta Board
Status: 🏁 Done
Milestone
v2 Alpha 3
Development

No branches or pull requests
1 participant
@Bonkles