egui-winit: Use RawDisplayHandle for smithay clipboard init #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
reviewed
Apr 18, 2023
crates/egui-winit/src/clipboard.rs
Outdated
Comment on lines
32
to
33
| /// The returned `Clipboard` must not outlive the input `_event_loop`. | ||
| pub fn new<T>(_event_loop: &EventLoopWindowTarget<T>) -> Self { | ||
| pub fn new(_display_target: impl HasRawDisplayHandle) -> Self { |
There was a problem hiding this comment.
Doc comment should be updated to refer to the new parameter name
crates/egui-winit/src/lib.rs
Outdated
Comment on lines
90
to
91
| /// The returned `State` must not outlive the input `_event_loop`. | ||
| pub fn new<T>(event_loop: &EventLoopWindowTarget<T>) -> Self { | ||
| pub fn new(display_target: impl HasRawDisplayHandle) -> Self { |
|
addressed the inline comments |
|
tip: configure your editor to run |
eframe
Relates to epi and eframe
egui-winit
porblems related to winit
and removed
eframe
Relates to epi and eframe
labels
Apr 19, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this addresses #2912