Add Context::request_repaint_after #1694

coderedart · 2022-05-28T20:09:56Z

Closes #1691.

kinda my first PR.

I am wondering whether i should store this idle timeout interval in platform output our full output. I did not implement this for wgpu yet, but should be pretty similar.

by storing it in platform output, it affects the take function and the Default derive to be manually implemented.

May 29, 2022 · 2022-05-29T18:24:15Z

Thanks for starting to work on this!

I think it is worth thinking through what the most common use cases for this feature would be.

If this is a setting ("minimal refresh interval") I think it would make most sense to have it as a member of eframe::App (similar to auto_save_interval, for instance).

However, there could be cases were an egui widget want to schedule a deferred repaint. For instance, a clock widget may want an update every second to show move the second hand. In this case it makes more sense to have it as a member of egui::Context (like is currently the case of this PR). In that case, we also want to make sure that if several widgets calls the function then we do a repaint after the shortest requested time. So if one widget needs updating every two seconds, and one every 500ms, the latter time is used no matter what order the widgets are called. Let's call this something like request_repaint_in with a Duration member. In this case we probably also want request_repaint and request_repaint_in(Duration::ZERO) to mean the exact same thing.

Thoughts?

coderedart · 2022-05-29T19:12:25Z

I thought it would be best to implement this in eframe too, but then i realized other non-eframe implementations might want this feature too and decided to use Context instead.

The primary purpose of this issue was to just have some sort of timeout interval for the next repaint callback.

I had two use cases in mind:

a simple stopwatch or timer app. if it is only showing seconds, then they only need to refresh every second. but request_repaint doesn't allow them to delay the repaint signal. and every time the app repaints, they can set the interval for the next frame by checking the current time and calculating how long before the seconds text displayed in gui needs to change. then, set that as the delay for the next frame. here, you want to make sure that the gui refreshes at this particular instant in future, regardless of whether it had input or not. if there's input, causing an earlier refresh, app will recalculate the timeout and set it again this frame.
a normal application like weather app or something, where you only want the gui to not be completely stale / dead due to idling in the background. here, you don't care about how long till a particular moment in time, but rather just a simple, maximum timeout like 5 seconds or something from the frame where it received the last input event. you can just provide the same duration every frame with no calculation.

I did not think about widgets explicitly wanting to set a timeout. but, I don't think that changes anything here.

my plan was to only just store the shortest duration too. as long as the repaint happens at or before the Instant desired by widget / user, they can recalculate their next duration according to their repaint needs just like in stop watch usecase.

I guess, that settles most questions.
request_repaint_in will take a duration, and will keep track of the smallest duration inside context. will provide that duration to backend in FullOutput along with the needs_repaint bool. winit/glfw/sdl will need to make sure to not idle longer than that duration waiting for events.

the name request_repaint_in is slightly misleading, but it should be fine. duration starts at the next frame. lets say for example that its a very inefficient app and takes 500 milliseconds per frame at 2 fps. the widget / user might want a repaint in next 500 milliseconds. now, app takes 1000 ms per frame (1 fps) because the backend event timeout takes 500 milli seconds AFTER the vsync swap buffer.

so, its not that we are requesting repaint within X duration. we are rather timing out during app idle time without any input events.
just need to mention this in the docs, so that they understand what is happening in the background.

May 29, 2022 · 2022-05-29T19:22:56Z

Good points! Perhaps request_repaint_after is a better name to communicate that the time starts ticking after the current frame finishes?

You can also use Duration::MAX to avoid using an Option (will make .min(…) easier to call)

coderedart and voladelta reacted with thumbs up emoji

coderedart · 2022-05-30T10:52:26Z

should i just replace needs_repaint bool with the repaint_after duration? then, checking for needs_repaint is simply repaint_after == Duration::ZERO

it will be a breaking change

May 30, 2022 · 2022-05-30T12:01:11Z

should i just replace needs_repaint bool with the repaint_after duration? then, checking for needs_repaint is simply repaint_after == Duration::ZERO

it will be a breaking change

Yeah, I think that sounds good!

egui/src/context.rs

coderedart · 2022-05-30T15:43:40Z

I have no idea how to deal with web, so i left it alone except changing the type signature in the logic function.
todo:

add to changelog about breaking change

eframe/src/web/backend.rs

egui/src/context.rs

coderedart · 2022-06-02T08:28:59Z

Unfortunately libspeechd is failing to link on my arch. So, I could not check for failures offline with --all-features. Had to commit and wait for ci workflow to run and show me errors to fix.

I hope this works now.

CHANGELOG.md

eframe/src/native/run.rs

eframe/src/web/events.rs

egui-winit/src/lib.rs

egui/src/context.rs

egui_glium/examples/native_texture.rs

egui_glium/examples/pure_glium.rs

egui_glow/examples/pure_glow.rs

egui_glow/src/winit.rs

egui/src/context.rs

Jun 10, 2022 · 2022-06-10T12:48:04Z

eframe/src/native/run.rs

@@ -194,7 +202,12 @@ pub fn run_glow(
                painter.destroy();
            }
            winit::event::Event::UserEvent(RequestRepaintEvent) => window.request_redraw(),
-            _ => (),
+            winit::event::Event::NewEvents(winit::event::StartCause::ResumeTimeReached {


You should be able to combine these with winit::event::Event::UserEvent(RequestRepaintEvent | winit::event::Event::NewEvents…

I have a feeling that we might see some sort of issue with repaint_after feature once people start using it.

so, i thought it would be better for debugging or adding special case handling for ResumeTimeReached event if both are treated as separate events.

coderedart · 2022-06-20T20:13:49Z

apologies for the delay. I had sudden irl stuff to take care of until yesterday and only now got to finally open my PC to work on this.

coderedart · 2022-06-21T06:17:20Z

think all CI should pass now. its been so long since i cared about grammar, that i forgot you capitalize first letter in a sentence :)

Jun 22, 2022 · 2022-06-22T11:19:22Z

Great job!

Follow-up to #1694

* Implement repaint_after for eframe web Follow-up to #1694 * cargo fmt * Simplify demo UI for "repaint_after"

start working on idle timeout repaint interval

df518bf

replace needs_repaint with repaint_after

9e780b6

coderedart marked this pull request as ready for review May 30, 2022 15:34

coderedart commented May 30, 2022

View reviewed changes

egui/src/context.rs Outdated Show resolved Hide resolved

forgot to reduce repaint_requests count at the end of frame.

80d47e1

May 30, 2022

View reviewed changes

eframe/src/web/backend.rs Outdated Show resolved Hide resolved

May 30, 2022

View reviewed changes

egui/src/context.rs Show resolved Hide resolved

coderedart added 7 commits May 30, 2022 22:27

set repaint_after to Duration::ZERO when repaint_requests is positive

f51a3e0

fix return type docs in web logic() function

07e6e23

fix accidental semi colon

5fb30b0

add to changelog

72a7d10

change egui glow to use repaint_after instead of needs_repaint

1e5ac46

change egui glium examples to use repaint_after instead of needs_repaint

9444ede

fix docs

2870d9e

Jun 10, 2022

View reviewed changes

coderedart added 2 commits June 21, 2022 01:34

fix some docs and other review suggestions

9976e47

fmt

1229a70

coderedart added 4 commits June 21, 2022 01:48

fix clippy fail

c4e3190

fix clippy glow

c1b3486

fix more clippy glow

4e8c031

fix more clippy glow

a4e0029

coderedart added 2 commits June 21, 2022 11:24

fix more clippy glow

b31e11b

add TODO to impl this in web

698cab0

start working on idle timeout repaint interval Add Context::request_repaint_after Jun 22, 2022

935913b into emilk:master Jun 22, 2022

Jun 22, 2022

Implement repaint_after for eframe web

798570c

Follow-up to #1694

Jun 22, 2022

Implement repaint_after for eframe web #1760

Merged

Jun 22, 2022

Implement repaint_after for eframe web (#1760)

eeae485

* Implement repaint_after for eframe web Follow-up to #1694 * cargo fmt * Simplify demo UI for "repaint_after"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Context::request_repaint_after #1694

Add Context::request_repaint_after #1694

coderedart commented May 28, 2022

May 29, 2022

coderedart commented May 29, 2022

May 29, 2022

coderedart commented May 30, 2022

May 30, 2022

coderedart commented May 30, 2022 •

edited

Loading

coderedart commented Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job - sorry for the slow review, but almost there now!

Jun 10, 2022

coderedart Jun 20, 2022

coderedart commented Jun 20, 2022

coderedart commented Jun 21, 2022

Jun 22, 2022

Add Context::request_repaint_after #1694

Add Context::request_repaint_after #1694

Conversation

coderedart commented May 28, 2022

May 29, 2022

coderedart commented May 29, 2022

May 29, 2022

coderedart commented May 30, 2022

May 30, 2022

coderedart commented May 30, 2022 • edited Loading

coderedart commented Jun 2, 2022

Choose a reason for hiding this comment

Jun 10, 2022

Choose a reason for hiding this comment

coderedart Jun 20, 2022

Choose a reason for hiding this comment

coderedart commented Jun 20, 2022

coderedart commented Jun 21, 2022

Jun 22, 2022

coderedart commented May 30, 2022 •

edited

Loading