Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [select, select-v2] add loading class to validateIcon #19379

Merged
merged 1 commit into from
Jan 2, 2025
Merged

feat(components): [select, select-v2] add loading class to validateIcon #19379

merged 1 commit into from
Jan 2, 2025

Conversation

LoTwT
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

description

The loading icon is static when enabling the status-icon and using custom validators in validating. But it has an animation in the el-input.

This PR is to add the corresponding class to let the loading status icon in the el-select and the el-select-v2 have an animation.

reproduction

reproduction URL

el-select-status-icon.mp4

@pull-request-triage Pull Request Triage
Copy link

👋 @LoTwT, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 24, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Hello @LoTwT, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 24, 2024

Open in Stackblitz

npm i https://pkg.pr.new/element-plus/element-plus@19379

commit: 85ba404

@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=19379
Please comment the example via this playground if needed.

Copy link
Contributor Author

demo URL after PR

btea
btea approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

warmthsea
warmthsea approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@warmthsea warmthsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@warmthsea warmthsea changed the title fix(components): [select, select-v2] add loading class to validateIcon feat(components): [select, select-v2] add loading class to validateIcon Jan 2, 2025
@warmthsea warmthsea merged commit 6bc4544 into element-plus:dev Jan 2, 2025
14 checks passed
@element-bot element-bot mentioned this pull request Jan 3, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmthsea warmthsea warmthsea approved these changes

@btea btea btea approved these changes

Assignees

LoTwT

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btea @warmthsea