Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [select] use option.isDisabled as the source of truth #19137

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix(components): [select] use option.isDisabled as the source of truth #19137

merged 2 commits into from
Dec 5, 2024

Conversation

makedopamine
Copy link
Collaborator

fix #19136

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Dec 5, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 5, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/element-plus/element-plus@19137

commit: bef9189

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=19137
Please comment the example via this playground if needed.

@btea
Copy link
Member

btea commented Dec 5, 2024

Is it convenient to add test cases for this scenario?

@makedopamine makedopamine requested a review from btea December 5, 2024 08:38
@btea btea merged commit be43878 into dev Dec 5, 2024
12 checks passed
@btea btea deleted the fix/select_disabled_option branch December 5, 2024 11:56
@element-bot element-bot mentioned this pull request Dec 13, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@makedopamine makedopamine

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [select] keyboard navigation doesn't skip disabled options
2 participants
@makedopamine @btea