Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): improve styles type by CSSProperties #18942

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(types): improve styles type by CSSProperties #18942

merged 1 commit into from
Nov 19, 2024

Conversation

thinkasany
Copy link
Contributor

@thinkasany thinkasany commented Nov 19, 2024 •
edited
Loading

No description provided.

@pull-request-triage Pull Request Triage
Copy link

👋 @thinkasany, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Hello @thinkasany, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 19, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18942

commit: 7c9caa8

@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=18942
Please comment the example via this playground if needed.

warmthsea
warmthsea approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@warmthsea warmthsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@warmthsea warmthsea merged commit 55dd94b into element-plus:dev Nov 19, 2024
14 checks passed
@element-bot element-bot mentioned this pull request Nov 22, 2024
Closed
3 tasks
jeffhuien pushed a commit to jeffhuien/element-plus that referenced this pull request Nov 23, 2024
@thinkasany @jeffhuien
fix(types): improve styles type by CSSProperties (element-plus#18942)
10c9ccf
@element-bot element-bot mentioned this pull request Nov 29, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmthsea warmthsea warmthsea approved these changes

Assignees

@thinkasany thinkasany

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkasany @warmthsea