Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [slider] no render popper dom when showTooltip is false #18667

Merged
merged 2 commits into from
Oct 27, 2024
Merged

fix(components): [slider] no render popper dom when showTooltip is false #18667

merged 2 commits into from
Oct 27, 2024

Conversation

zzjiaxiang
Copy link
Contributor

fix #18346

about #5250

@pull-request-triage Pull Request Triage
Copy link

👋 @zzjiaxiang, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Oct 26, 2024
@github-actions GitHub Actions
Copy link

Hello @zzjiaxiang, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 26, 2024 •
edited
Loading

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 26, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 26, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18667

commit: e2f4c6c

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 26, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=18667
Please comment the example via this playground if needed.

@zzjiaxiang
Copy link
Contributor Author

demo

@tolking tolking changed the title refactor(components): [slider] no render popper dom when showTooltip is false fix(components): [slider] no render popper dom when showTooltip is false Oct 27, 2024
btea
btea approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit 36193cc into element-plus:dev Oct 27, 2024
12 checks passed
@zzjiaxiang zzjiaxiang deleted the refactor branch October 27, 2024 06:40
@element-bot element-bot mentioned this pull request Nov 1, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@tolking tolking tolking approved these changes

Assignees

@zzjiaxiang zzjiaxiang

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [slider] el-slider设置showTooltip为false时依然生成poper元素
3 participants
@zzjiaxiang @tolking @btea