Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(components): [popper] popper border error #18635

Merged
merged 1 commit into from
Oct 27, 2024
Merged

style(components): [popper] popper border error #18635

merged 1 commit into from
Oct 27, 2024

Conversation

Liao-js
Copy link
Contributor

@Liao-js Liao-js commented Oct 22, 2024

fix #18631
Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @Liao-js, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Hello @Liao-js, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18635

commit: 426b177

@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=18635
Please comment the example via this playground if needed.

btea
btea approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit 72c3ce1 into element-plus:dev Oct 27, 2024
14 checks passed
@element-bot element-bot mentioned this pull request Nov 1, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@tolking tolking tolking approved these changes

Assignees

@Liao-js Liao-js

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
3 participants
@Liao-js @tolking @btea