-
-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [table-v2] header rendering is misplaced #18628
Conversation
commit: |
🧪 Playground Preview: https://element-plus.run/?pr=18628 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestion, this is indeed a more reasonable approach. |
Yeah, it has been adjusted. |
On the contrary, I think the 07f5d25 method is the best, because now onUpate is executed too many times and many useless operations are performed. (Personal feeling) |
Yeah, I tried both methods, and onUpdate still gets triggered unnecessarily during scrolling. However, I believe that directly extracting value from props is better than accessing DOM variables multiple times. Additionally, if I want to reduce the number of calls, I think it can be done like this: |
Good Catch 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.fix #18557