Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [select-v2] group label overflow hidden #18551

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(components): [select-v2] group label overflow hidden #18551

merged 1 commit into from
Oct 28, 2024
+5 −1

Conversation

zzjiaxiang
Copy link
Contributor

@zzjiaxiang zzjiaxiang commented Oct 14, 2024 •
edited
Loading

fix: 18548

before:

image

after:

image

@pull-request-triage Pull Request Triage
Copy link

👋 @zzjiaxiang, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Oct 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Hello @zzjiaxiang, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@zzjiaxiang zzjiaxiang changed the title fix(components): [select-v2] overflow hidden fix(components): [select-v2] group label no overflow hidden Oct 14, 2024
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 16, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18551

commit: c411dd1

@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=18551
Please comment the example via this playground if needed.

@zzjiaxiang zzjiaxiang changed the title fix(components): [select-v2] group label no overflow hidden fix(components): [select-v2] group label overflow hidden Oct 24, 2024
btea
btea approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@warmthsea warmthsea merged commit e306995 into element-plus:dev Oct 28, 2024
15 checks passed
@zzjiaxiang zzjiaxiang deleted the fix-select-v2-style branch October 28, 2024 09:30
@element-bot element-bot mentioned this pull request Nov 1, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmthsea warmthsea warmthsea approved these changes

@btea btea btea approved these changes

Assignees

@zzjiaxiang zzjiaxiang

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [select-v2] 分组的文字太长超出弹窗时，会换行并遮挡下面的选项
3 participants
@zzjiaxiang @btea @warmthsea