Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [transfer] render the option's label correctly when there's only an empty comment in the default slot #18416

Merged
merged 3 commits into from
Oct 2, 2024
Merged

fix(components): [transfer] render the option's label correctly when there's only an empty comment in the default slot #18416

merged 3 commits into from
Oct 2, 2024

Conversation

LoTwT
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

description

This PR is to resolve #18415.

@pull-request-triage Pull Request Triage
Copy link

👋 @LoTwT, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 29, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Hello @LoTwT, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 29, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18416

commit: e368a20

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 29, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=18416
Please comment the example via this playground if needed.

btea
btea approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit 86b01ee into element-plus:dev Oct 2, 2024
12 checks passed
@element-bot element-bot mentioned this pull request Oct 11, 2024
Merged
3 tasks
Open
@yangzhen1234 yangzhen1234 mentioned this pull request Nov 5, 2024
Open
@Ramyromel Ramyromel mentioned this pull request Nov 11, 2024
Open
@yangzhen1234 yangzhen1234 mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

LoTwT

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [transfer] Fail to render the option's label when there's an empty comment in the default slot
2 participants
@btea