Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(docs): remove Vite #18383

Merged
merged 2 commits into from
Sep 30, 2024
Merged

refactor(docs): remove Vite #18383

merged 2 commits into from
Sep 30, 2024

Conversation

makedopamine
Copy link
Collaborator

Since VitePress already includes Vite, there is no need to install Vite separately.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 26, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18383

commit: 1e6db23

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=18383
Please comment the example via this playground if needed.

@bastarder bastarder requested review from bastarder and removed request for bastarder September 28, 2024 02:50
btea
btea approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warmthsea
Copy link
Collaborator

Sorry, I pulled the wrong version, I pulled it to master 😅

@warmthsea warmthsea merged commit ccc8bdc into dev Sep 30, 2024
12 checks passed
@warmthsea warmthsea deleted the refactor/docs_vite branch September 30, 2024 10:41
@element-bot element-bot mentioned this pull request Oct 11, 2024
Merged
3 tasks
Open
@yangzhen1234 yangzhen1234 mentioned this pull request Nov 5, 2024
Open
@Ramyromel Ramyromel mentioned this pull request Nov 11, 2024
Open
@yangzhen1234 yangzhen1234 mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmthsea warmthsea warmthsea approved these changes

@btea btea btea approved these changes

Assignees

@makedopamine makedopamine

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makedopamine @warmthsea @btea