Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [dropdown-item] remove redundant attributes #18340

Merged
merged 1 commit into from
Oct 13, 2024
Merged

fix(components): [dropdown-item] remove redundant attributes #18340

merged 1 commit into from
Oct 13, 2024

Conversation

betavs
Copy link
Contributor

@betavs betavs commented Sep 23, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

close #18337

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @betavs, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Hello @betavs, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 23, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 23, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18340

commit: b777625

@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=18340
Please comment the example via this playground if needed.

btea
btea approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the impact may be small, this seems to be a breaking change. Should we mark it somewhere?

@btea btea merged commit 88bf23e into element-plus:dev Oct 13, 2024
14 checks passed
@element-bot element-bot mentioned this pull request Oct 18, 2024
Merged
3 tasks
@Ramyromel Ramyromel mentioned this pull request Nov 11, 2024
Open
@yangzhen1234 yangzhen1234 mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makedopamine makedopamine makedopamine left review comments

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@betavs betavs

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [dropdown-item] Dropdown item duplicates id attribute when the divided flag is set
4 participants
@betavs @tolking @btea @makedopamine