Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [time-picker] close pick when click clear on pick open #15390

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix(components): [time-picker] close pick when click clear on pick open #15390

merged 2 commits into from
Sep 12, 2024

Conversation

wzc520pyfm
Copy link
Contributor

closed #15355

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @wzc520pyfm, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=15390
Please comment the example via this playground if needed.

@wzc520pyfm
Copy link
Contributor Author

Demo

@warmthsea warmthsea enabled auto-merge (squash) September 12, 2024 07:49
@warmthsea warmthsea disabled auto-merge September 12, 2024 09:41
btea
btea approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit 2a56811 into element-plus:dev Sep 12, 2024
12 checks passed
@element-bot element-bot mentioned this pull request Sep 13, 2024
Merged
3 tasks
Open
Open
@yangzhen1234 yangzhen1234 mentioned this pull request Nov 5, 2024
Open
@Ramyromel Ramyromel mentioned this pull request Nov 11, 2024
Open
@yangzhen1234 yangzhen1234 mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmthsea warmthsea warmthsea approved these changes

@btea btea btea approved these changes

@tolking tolking tolking approved these changes

Assignees

@wzc520pyfm wzc520pyfm

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [time-picker] TimePicker click the clearable button does not clear data
4 participants
@wzc520pyfm @tolking @btea @warmthsea