-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flowtype migration #607
Flowtype migration #607
Conversation
@dustintownsend for some reason I can add you as a reviewer. Would be great if you could review this. When should this be merged? The This allows for better static analysis when developing. Also if I'm not mistaken, Is this okay to be merged now? |
@dustintownsend accidentally tagged the wrong person. Meant to tag you in #607 (comment). Would be great if you could respond to it. |
@amilajack I really need to learn more about flow. I assume it's basically just making javascript more like typescript. For the benefit of catching typos/code mistakes in the editor. I'm not 100% sure what I'm looking for here, but I see the same warnings from #610 but in the editor. ESLint warnings for |
@dustintownsend Hmm try restarting the editor. Here's what I see: Try restarting atom |
@amilajack if I add Is that the expected behavior? |
Yea. |
This essentially requires the user of the boilerplate to know at least a little flow. Lets merge this when we provide some learning resources and documentation on the tools that this boilerplate uses
eslint-plugin-flowtype-errors
eslint-plugin-flowtype
babel-plugin-tcomb
static propTypes
to flow types