rusk-abi: Add transaction execution function #3186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c53d2c to
15623e0
Compare
9b1f758 to
eaf0a6a
Compare
Add: - `transfer::data::Bytecode.verify_hash` - `transfer::Transaction.deploy_charge` execution-core
eaf0a6a to
87fd7a8
Compare
HDauven
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
LGTM, very nice how we can get rid of the execute in test utils
It might be good to wait for a second opinion from @miloszm or @herr-seppia though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to move
executetorusk-abisome contract-deployment functionalities had to move as well:execution-core::transfer::Transaction.deploy_chargeexecution-core::transfer::data::Bytecode.verify_hashrusk-abi::gen_contract_idResolves #3185