Another round of polishing staged releases #11342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set env variable UPLOAD_ASSETS_TO_STAGING_TARGET instead to pass information to script/upload-assets-to-staging.sh
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 30, 2024
Merge pull request duckdb/duckdb#11252 from hannes/re2upgrade Merge pull request duckdb/duckdb#11355 from szarnyasg/remove-issue-labeling-workflow Merge pull request duckdb/duckdb#11342 from carlopi/fix_staged_releases Merge pull request duckdb/duckdb#11341 from szarnyasg/iss11339
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 30, 2024
Merge pull request duckdb/duckdb#11252 from hannes/re2upgrade Merge pull request duckdb/duckdb#11355 from szarnyasg/remove-issue-labeling-workflow Merge pull request duckdb/duckdb#11342 from carlopi/fix_staged_releases Merge pull request duckdb/duckdb#11341 from szarnyasg/iss11339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make so that Windows.yml and Windows invocation of Java.yml use OVERRIDE_GIT_DESCRIBE.
And make so Python uploads the staged artifact to the same folder as the others (difference is that in Python the tag is potentially overridden, so original info need to be passed around).
Test checking this works properly is in this run of the testing duckdb fork: https://github.com/duckdb/duckdb-test-staging/actions/runs/8422603747
Up next: deploying extensions in a (yet to be decided) known place (currently if both nightly AND staged releases workflow are run on the same hash they will override each other).