Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make buttons more responsive #263

Merged
drawdb-io:main from
Oct 19, 2024

Conversation

dantemogrim
Copy link

On tablets and larger phone screens, these two were lacking a margin setting (leading to a "squished" look). This commit resolves that.

Before:

Screenshot 2024-10-14 at 18 09 48 Screenshot 2024-10-14 at 18 10 14

After:

Screenshot 2024-10-14 at 18 12 59 Screenshot 2024-10-14 at 18 13 58

On tablets and larger phone screens, these two were lacking a margin
setting (leading to a "squished" look). This commit resolves that.
Copy link

vercel bot commented Oct 14, 2024

Someone is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 8:26am

Copy link
Member

@1ilit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick. While it looks great on most screens, the button contents get wrapped around on smaller screens:
image

Not critical but we can do better
image
image

What you can do is remove all the flex stuff and have something like this:

<div className="...">
    <button className="inline-block mt-2 me-3 ...">btn1</button>
    <button className="inline-block mt-2 ...">btn2</button>
<div>

This way the buttons will just wrap around whenever the screen gets too small. The me of btn1 will space out the buttons when they're horizontal, the mt of btn spaces them out when they're vertical, and the mt of btn1 makes sure they're on the same level when horizontal.

Let me know if you have any thoughts

@dantemogrim
Copy link
Author

Sounds like a good idea! I'll try to make it happen.😊

Copy link
Member

@1ilit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you

de84c08 into drawdb-io:main Oct 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants