This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -22,7 +22,7 @@ Swarm clusters in business critical production environments. The following high | |||
|
|||
## Security | |||
|
|||
There are many aspects to securing a Docker Swarm cluster. This section covers: | |||
There are many aspects to secure a Docker Swarm cluster. This section covers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think securing
is actually correct here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
securing
is correct
Ping @moxiegirl |
@@ -60,16 +60,16 @@ the different components of a Swam cluster listen on. You should use these to | |||
configure your firewalls and other network access control lists. | |||
|
|||
- **Swarm manager.** | |||
- **Inbound 80/tcp (HTTP)**. This is allows `docker pull` commands to work. If you will be pulling from Docker Hub you will need to allow connections on port 80 from the internet. | |||
- **Inbound 80/tcp (HTTP)**. This allows `docker pull` commands to work. If you will be pulling from Docker Hub you will need to allow connections on port 80 from the internet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change all instances of:
If you will be pulling from Docker Hub you will need to allow connections on port 80 from the internet
to
If you plan to pull images from Docker Hub, you must allow Internet connections through port 80.
Thanks for the contribution @allencloud --- some small corrections. |
85065b3
to
e131bb8
Compare
Ping @moxiegirl |
LGTM 👍 |
Signed-off-by: Sun Hongliang <[email protected]>
e131bb8
to
bb4a26f
Compare
Thanks @allencloud ! |
ChristianKniep
pushed a commit
to ChristianKniep/swarm
that referenced
this pull request
Jul 27, 2017
fix typos in docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sun Hongliang [email protected]