This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Fix Consul Lock TTL with store failure #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dtepeneu |
1816148 to
5a127e8
Compare
If using the Lock TTL feature with Consul, the code path in libkv is issuing a Put in the background through the PeriodicRenewal call. The error is then eaten up and ignored on the candidate loop. This would lead to the candidate and followers being stuck in their candidate loop. Consequence would be that they would not retry to take the lock ending in a state with no Leader. This patch restores an explicit error check instead of wrongfully passing on the error to the channel before giving it back to the caller. Signed-off-by: Alexandre Beslic <[email protected]>
5a127e8 to
5e8998e
Compare
|
@vieux there seems to be an issue on the |
|
LGTM |
1 similar comment
|
LGTM |
Fix Consul Lock TTL with store failure
|
Thank you Alex and the entire swarm team for such a quick fix! |
ChristianKniep
pushed a commit
to ChristianKniep/swarm
that referenced
this pull request
Jul 27, 2017
…e_failure Fix Consul Lock TTL with store failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1545
If using the Lock TTL feature with Consul, the code
path in libkv is issuing a Put in the background through
the PeriodicRenewal call. The error is then eaten up and
ignored on the candidate loop. This would lead to the
candidate and followers being stuck in their candidate
loop. Consequence would be that they would not retry to
take the lock ending in a state with no Leader.
This patch restores an explicit error check instead of
wrongfully passing on the error to the channel before
giving it back to the caller.
Signed-off-by: Alexandre Beslic [email protected]