Added explicit pagy.manifest to comply with rubocop-packaging (see also

ddnexus#297)
dmitry · Apr 17, 2021 · a49ae2a · a49ae2a
1 parent 98cbb2e
commit a49ae2a
Show file tree

Hide file tree

Showing 6 changed files with 120 additions and 18 deletions.
diff --git a/.gitignore b/.gitignore
@@ -2,6 +2,7 @@
 /.yardoc
 /_yardoc/
 /coverage/
+/pkg/
 /tmp/
 /docs/.jekyll-metadata
 /.idea/
diff --git a/Gemfile b/Gemfile
@@ -5,20 +5,20 @@ source 'https://rubygems.org'
 
 # gemspec
 
-gem 'rake'
-gem 'rack'
 gem 'i18n'
-
 gem 'oj', require: false     # false is for testing with or without it
+gem 'rack'
+gem 'rake'
+gem 'rake-manifest'
 
 group :test do
   gem 'codecov', require:  false
   gem 'minitest'
   gem 'minitest-reporters'
-  gem 'rubocop'
-  gem 'rubocop-minitest'
-  gem 'rubocop-performance'
-  gem 'rubocop-rake'
+  gem 'rubocop', require: false
+  gem 'rubocop-minitest', require: false
+  gem 'rubocop-performance', require: false
+  gem 'rubocop-rake', require: false
   gem 'simplecov', require: false
 end
 
@@ -30,8 +30,12 @@ group :apps do
 end
 
 # group :performance do
-  # benchmark/profiling
   # gem 'benchmark-ips'
   # gem 'kalibera'
   # gem 'memory_profiler'
 # end
+
+group :ide_development do
+  gem 'debase'
+  gem 'ruby-debug-ide'
+end
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -7,6 +7,9 @@ GEM
     codecov (0.5.1)
       simplecov (>= 0.15, < 0.22)
     concurrent-ruby (1.1.8)
+    debase (0.2.4.1)
+      debase-ruby_core_source (>= 0.10.2)
+    debase-ruby_core_source (0.10.12)
     docile (1.3.5)
     i18n (1.8.9)
       concurrent-ruby (~> 1.0)
@@ -28,6 +31,7 @@ GEM
       rack
     rainbow (3.0.0)
     rake (13.0.3)
+    rake-manifest (0.2.0)
     regexp_parser (2.1.1)
     rexml (3.2.5)
     rubocop (1.12.1)
@@ -48,6 +52,8 @@ GEM
       rubocop-ast (>= 0.4.0)
     rubocop-rake (0.5.1)
       rubocop
+    ruby-debug-ide (0.7.2)
+      rake (>= 0.8.1)
     ruby-progressbar (1.11.0)
     ruby2_keywords (0.0.4)
     simplecov (0.21.2)
@@ -75,16 +81,19 @@ PLATFORMS
 
 DEPENDENCIES
   codecov
+  debase
   i18n
   minitest
   minitest-reporters
   oj
   rack
   rake
+  rake-manifest
   rubocop
   rubocop-minitest
   rubocop-performance
   rubocop-rake
+  ruby-debug-ide
   simplecov
   sinatra
   sinatra-contrib

diff --git a/Rakefile b/Rakefile
@@ -6,11 +6,23 @@ require 'bundler/gem_tasks'
 require 'rake/testtask'
 require 'json'
 
-if ENV['RUBOCOP'] || !ENV['CI']
+if ENV['RUBOCOP'] == 'true' || !ENV['CI']
   require "rubocop/rake_task"
   RuboCop::RakeTask.new(:rubocop)
 end
 
+unless ENV['CI']
+  require 'rake/manifest'
+  Rake::Manifest::Task.new do |t|
+    t.patterns      = %w[lib/**/* LICENSE.txt]
+    t.patterns      = FileList.new.include('lib/**/*', 'LICENSE.txt').exclude('**/*.md')
+    t.manifest_file = 'pagy.manifest'
+  end
+
+  desc 'Build the gem, checking the manifest first'
+  task build: 'manifest:check'
+end
+
 # Separate tasks for each test that must run a process
 # in isolation in order to avoid affecting also other tests.
 test_tasks = {}

diff --git a/pagy.gemspec b/pagy.gemspec
@@ -6,14 +6,14 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'pagy'
 
 Gem::Specification.new do |s|
-  s.name          = 'pagy'
-  s.version       = Pagy::VERSION
-  s.authors       = ['Domizio Demichelis']
-  s.email         = ['[email protected]']
-  s.summary       = 'The Ultimate Pagination Ruby Gem'
-  s.description   = 'Agnostic pagination in plain ruby: it works with any framework, ORM and DB type, with all kinds of collections, even pre-paginated, scopes, Arrays, JSON data... Easy, powerful, fast and light.'
-  s.homepage      = 'https://github.com/ddnexus/pagy'
-  s.license       = 'MIT'
-  s.files         = `git ls-files -z`.split("\x0").select{|f| f.start_with?('lib', 'pagy.gemspec', 'LICENSE') }
+  s.name        = 'pagy'
+  s.version     = Pagy::VERSION
+  s.authors     = ['Domizio Demichelis']
+  s.email       = ['[email protected]']
+  s.summary     = 'The Ultimate Pagination Ruby Gem'
+  s.description = 'Agnostic pagination in plain ruby: it works with any framework, ORM and DB type, with all kinds of collections, even pre-paginated, scopes, Arrays, JSON data... Easy, powerful, fast and light.'
+  s.homepage    = 'https://github.com/ddnexus/pagy'
+  s.license     = 'MIT'
+  s.files       = File.read('pagy.manifest').split
   s.required_ruby_version = ['>= 1.9', '< 3.0']   # rubocop:disable Gemspec/RequiredRubyVersion
 end
diff --git a/pagy.manifest b/pagy.manifest
@@ -0,0 +1,76 @@
+lib/config/pagy.rb
+lib/javascripts/pagy.js
+lib/locales/bg.yml
+lib/locales/bs.yml
+lib/locales/ca.yml
+lib/locales/cs.yml
+lib/locales/da.yml
+lib/locales/de.yml
+lib/locales/en.yml
+lib/locales/es.yml
+lib/locales/fr.yml
+lib/locales/hr.yml
+lib/locales/id.yml
+lib/locales/it.yml
+lib/locales/ja.yml
+lib/locales/km.yml
+lib/locales/ko.yml
+lib/locales/nb.yml
+lib/locales/nl.yml
+lib/locales/pl.yml
+lib/locales/pt-BR.yml
+lib/locales/pt.yml
+lib/locales/ru.yml
+lib/locales/sr.yml
+lib/locales/sv-SE.yml
+lib/locales/sv.yml
+lib/locales/sw.yml
+lib/locales/tr.yml
+lib/locales/utils/i18n.rb
+lib/locales/utils/loader.rb
+lib/locales/utils/p11n.rb
+lib/locales/zh-CN.yml
+lib/locales/zh-HK.yml
+lib/locales/zh-TW.yml
+lib/pagy.rb
+lib/pagy/backend.rb
+lib/pagy/countless.rb
+lib/pagy/exceptions.rb
+lib/pagy/extras/arel.rb
+lib/pagy/extras/array.rb
+lib/pagy/extras/bootstrap.rb
+lib/pagy/extras/bulma.rb
+lib/pagy/extras/countless.rb
+lib/pagy/extras/elasticsearch_rails.rb
+lib/pagy/extras/foundation.rb
+lib/pagy/extras/headers.rb
+lib/pagy/extras/i18n.rb
+lib/pagy/extras/items.rb
+lib/pagy/extras/materialize.rb
+lib/pagy/extras/metadata.rb
+lib/pagy/extras/navs.rb
+lib/pagy/extras/overflow.rb
+lib/pagy/extras/pagy_search.rb
+lib/pagy/extras/searchkick.rb
+lib/pagy/extras/semantic.rb
+lib/pagy/extras/shared.rb
+lib/pagy/extras/support.rb
+lib/pagy/extras/trim.rb
+lib/pagy/extras/uikit.rb
+lib/pagy/frontend.rb
+lib/templates/bootstrap_nav.html.erb
+lib/templates/bootstrap_nav.html.haml
+lib/templates/bootstrap_nav.html.slim
+lib/templates/bulma_nav.html.erb
+lib/templates/bulma_nav.html.haml
+lib/templates/bulma_nav.html.slim
+lib/templates/foundation_nav.html.erb
+lib/templates/foundation_nav.html.haml
+lib/templates/foundation_nav.html.slim
+lib/templates/nav.html.erb
+lib/templates/nav.html.haml
+lib/templates/nav.html.slim
+lib/templates/uikit_nav.html.erb
+lib/templates/uikit_nav.html.haml
+lib/templates/uikit_nav.html.slim
+LICENSE.txt