Fixed #35924 - Removed choose/remove all controls used in FilteredSelectMultiple widget #18927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trols used in FilteredSelectMultiple widget
sarahboyce
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Thank you @ajosephau ⭐
I think we should also tweak the css of these buttons to be a bit more like a button
--- a/django/contrib/admin/static/admin/css/widgets.css
+++ b/django/contrib/admin/static/admin/css/widgets.css
@@ -157,16 +157,16 @@
.selector-chooseall, .selector-clearall {
display: inline-block;
- height: 16px;
text-align: left;
+ padding: 4px 5px;
margin: 0 auto;
overflow: hidden;
font-weight: bold;
- line-height: 16px;
color: var(--body-quiet-color);
text-decoration: none;
opacity: 0.55;
border: none;
+ border-radius: 4px;
}These changes makes it look like this:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35924
Branch description
Rremoved CSS class references for choose/remove all controls used in FilteredSelectMultiple widget
Checklist
mainbranch.