Fixed #35911 -- FilteredSelectMultiple Widget Not Functional in Inline Formset After Form Deletion #18903
+144
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… causes filter to reset
…mpleted and passing test case for new filtered select functionality
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
|
There are a same issue already exists in select2 (autocomplete in inline formset) |
sarahboyce
reviewed
Dec 17, 2024
| @@ -1,63 +1,17 @@ | |||
| import globals from "globals"; | |||
There was a problem hiding this comment.
Please revert these changes
Comment on lines
+20
to
+25
| venv/ | ||
| .venv/ | ||
| env/ | ||
| .env/ | ||
| myproject/staticfiles | ||
| myproject/ |
There was a problem hiding this comment.
Please revert these changes
Comment on lines
+33
to
+43
|
|
||
| // document.addEventListener('formset:added', function(e) { | ||
| // const formId = e.target.id; // Get the form ID | ||
| // const newField = formId.querySelector('select.selectfilter'); | ||
| // if (newField) { | ||
| // const fieldName = newField.dataset.fieldName; | ||
| // const isStacked = parseInt(newField.dataset.isStacked, 10); | ||
| // SelectFilter.init(newField.id, fieldName, isStacked); | ||
| // } | ||
| // }); | ||
|
|
There was a problem hiding this comment.
We try not to comment out blocks of code. If this is not needed, it should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number: 35911
ticket-35911
Branch description
This PR addressed the issue where the FilteredSelectMultiple widget became non-functional when inline formsets in Django admin were dynamically deleted. The widget's icons and dropdown filters failed to refresh correctly, and event handlers were not reinitialized, causing usability issues.
The implemented solution focused on improving the handling of icons and dropdown filters. The key changes included:
Checklist
mainbranch.