Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: num rows statistics #2990

Merged
merged 2 commits into from
Nov 22, 2024
Merged

fix: num rows statistics #2990

merged 2 commits into from
Nov 22, 2024

Conversation

lewiszlw
Copy link
Contributor

Description

This pr is to get correct num_rows statistics for optimizing select count(*) from xxx case.

Related Issue(s)

Documentation

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Nov 13, 2024
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@lewiszlw lewiszlw changed the title Fix num rows statistics fix: num rows statistics Nov 13, 2024
@lewiszlw lewiszlw force-pushed the fix-num-rows-stat branch 2 times, most recently from 7e11cbf to 4883f0c Compare November 13, 2024 06:19
@rtyler rtyler enabled auto-merge November 21, 2024 21:48
@rtyler rtyler added this to the v0.22 milestone Nov 21, 2024
Signed-off-by: Linwei Zhang<[email protected]>
Signed-off-by: 张林伟 <[email protected]>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.41%. Comparing base (cb80931) to head (e858cae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2990      +/-   ##
==========================================
- Coverage   72.47%   72.41%   -0.07%     
==========================================
  Files         128      128              
  Lines       40857    40859       +2     
  Branches    40857    40859       +2     
==========================================
- Hits        29613    29588      -25     
+ Misses       9360     9356       -4     
- Partials     1884     1915      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rtyler rtyler added this pull request to the merge queue Nov 22, 2024
Merged via the queue into delta-io:main with commit cd9c9d5 Nov 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants