Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs for empty page OutOfRangeError #69

Merged
merged 1 commit into from
Jul 13, 2018
Merged

docs for empty page OutOfRangeError #69

merged 1 commit into from
Jul 13, 2018

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jul 12, 2018

screen shot 2018-07-11 at 8 38 26 pm

for #68

ddnexus
ddnexus reviewed Jul 12, 2018
View reviewed changes
docs/how-to.md Outdated

private

def redirect_to_last_page
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have an exception argument?

@grosser grosser force-pushed the grosser/out-of-bounds branch from 1b8523f to d291318 Compare July 12, 2018 16:24
@grosser
Copy link
Contributor Author

grosser commented Jul 12, 2018

good catch, fixed!

@ddnexus ddnexus merged commit 3d732dd into ddnexus:master Jul 13, 2018
@ddnexus
Copy link
Owner

ddnexus commented Jul 13, 2018

Thanks

@ddnexus ddnexus added the merged label Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddnexus ddnexus ddnexus left review comments

Assignees
No one assigned
Labels
merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grosser @ddnexus