-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Anchor_string does not apply to disabled anchors #732
Comments
Hi @ibrahima, That's an inconsistency which should be considered a bug, so this issue is valid. Your particular example is good for highlighting the inconsistent behavior, however using the You can target the anchors with a CSS rule, and with the Will fix ASAP. |
work in progress commit to fix: issue #732. i have only done the pagy_nav helper so far. I want to make sure i am on the correct track fix: rematch-rebuild the anchor-string for the calendar extra
92fd345 - all i did was add it in the markup for the anchor-string for the gaps and current pages. Is this the correct approach? I can easily do for the other nav helpers and add tests. |
OK, so I finally had a bit of time to analyze the matter properly. The main goal of the Now, using In conclusion the On the other hand, the docs require changes to fix and clarify the matter. Will do ASAP. |
Thanks for looking into it! |
👀 Before submitting...
🧐 REQUIREMENTS
💬 Description
Hi! I'm just getting started with pagy, and I was trying to figure out how best to style it within the context of my application. I wanted to apply some classes that are already defined to the anchors. I noticed though that the
anchor_string
argument only applies to the non-disabled anchors, which isn't what I'd want personally. Is this intentional, or a bug? Thank you!Here's my reproduction: https://gist.github.com/ibrahima/cc448df2be46b6c22095d9de3a9e2ffa#file-repro-ru
The relevant portion is
and
I was expecting in this example that all the anchors would be turned red, even the disabled ones.
I understand if this is intended behavior, I can figure out a different way to style things. I was just trying to understand if this was intentional. Thank you!
The text was updated successfully, but these errors were encountered: