C#: Review comments. Keep the TContent type pribate

davidvenegasr · Nov 26, 2021 · d4f3a6d · d4f3a6d
1 parent b9d0a60
commit d4f3a6d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowUtil.qll b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowUtil.qll
@@ -164,7 +164,7 @@ predicate simpleLocalFlowStep(Node node1, Node node2) {
     pragma[only_bind_out](node2.getEnclosingCallable())
 }
 
-newtype TContent =
+private newtype TContent =
   TFieldContent(InstanceField f) or
   TArrayContent() or
   TCollectionContent() or

diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImplSpecific.qll b/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImplSpecific.qll
@@ -75,12 +75,14 @@ SummaryComponent interpretComponentSpecific(string c) {
 /** Gets the summary component for specification component `c`, if any. */
 private string getContentSpecificCsv(Content c) {
   exists(Field f, string package, string className, string fieldName |
-    c = TFieldContent(f) and
+    f = c.(FieldContent).getField() and
     f.hasQualifiedName(package, className, fieldName) and
     result = "Field[" + package + "." + className + "." + fieldName + "]"
   )
   or
-  exists(SyntheticField f | c = TSyntheticFieldContent(f) and result = "SyntheticField[" + f + "]")
+  exists(SyntheticField f |
+    f = c.(SyntheticFieldContent).getField() and result = "SyntheticField[" + f + "]"
+  )
   or
   c instanceof ArrayContent and result = "ArrayElement"
   or