Handle coverage the same was as exunit #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the end user to use custom coverage tools.
| test_modules(post_config[:erlc_paths], options[:patterns]) | ||
| |> Enum.map(&module_name_from_path/1) | ||
| |> Enum.drop_while(fn(m) -> | ||
| tests_pass?(m, options[:eunit_opts] ++ post_config[:eunit_opts]) end) | ||
| if(options[:cover], do: cover_analyse()) | ||
|
|
||
| cover && cover.() |
There was a problem hiding this comment.
I don't get how this works. It looks like cover is either nil or a Keyword. How would cover.() work?
There was a problem hiding this comment.
cover is either nil or a function. Cover.start/2 returns a function that does the analysis and writes the output.
The code for the default Cover module is here: https://github.com/elixir-lang/elixir/blob/master/lib/mix/lib/mix/tasks/test.ex#L2
There was a problem hiding this comment.
OK, so I think this is just a bit of funkyness with variable names (like having a couple things named cover). Can we do something like
def run(args) do
# .. existing code
# line 55
cover_callback = start_cover_tool(options[:cover], project)
# lines 63-66 same
# line 68
execute_cover_callback(cover_callback)
end
# no cover tool specified
defp start_cover_tool(nil, _project), do: nil
# set up the cover tool
defp start_cover_tool(cover_tool, project) do
compile_path = Mix.Project.compile_path(project)
cover = Keyword.merge(@cover, project[:test_coverage] || [])
# returns a callback
cover[:tool].start(compile_path, cover)
end
# no cover tool was specified
defp execute_cover_callback(nil), do: :ok
# run the cover callback
defp execute_cover_callback(cb), do: cb.()
added 2 commits
August 25, 2016 12:34
* master: Replace List.keymember? with Keyword.has_key? Add eunit_formatters for better output Make sure test failures cause the task to fail Run the tests all at once rather than individually # Conflicts: # lib/mix/tasks/eunit.ex
|
@dantswain Done. Let me know what you think. |
|
👍 |
and Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the end user to use custom coverage tools.