Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-460 upgraded cypress to its latest #470

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Issue-460 upgraded cypress to its latest #470

merged 3 commits into from
Jun 23, 2023

Conversation

Cronus1007
Copy link
Member

@Cronus1007 Cronus1007 commented Mar 22, 2023 •
edited by TimidRobot
Loading

Fixes

Description

Upgraded Cypress from version 6 to latest.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Cronus1007 Cronus1007 requested review from a team as code owners March 22, 2023 15:18
@Cronus1007 Cronus1007 requested review from TimidRobot, Shafiya-Heena and kgodey and removed request for a team March 22, 2023 15:18
@Cronus1007 Cronus1007 marked this pull request as draft March 22, 2023 15:18
@Cronus1007
Copy link
Member Author

@possumbilities Here I have upgraded Cypress to its latest version and locally everything is working fine. I have raised the PR only to check CI/CD pipelines.I am not done with the PR right now that's why marking it as a draft.

@Cronus1007 Cronus1007 mentioned this pull request Mar 22, 2023
Closed
1 task
@Cronus1007 Cronus1007 marked this pull request as ready for review March 24, 2023 13:32
@Cronus1007
Copy link
Member Author

@possumbilities I have updated the test case. Could you please have a look upon this?

possumbilities
possumbilities approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@possumbilities possumbilities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cronus1007 This should be tremendously helpful! Thankyou!

As best as I can test this all checks out and passed.

Approve!

@possumbilities possumbilities merged commit 324ba5c into main Jun 23, 2023
@possumbilities possumbilities deleted the issue-460 branch June 23, 2023 19:25
@TimidRobot
Copy link
Member 

Test Suites: 15 passed, 15 total
Tests:       170 passed, 170 total
Snapshots:   0 total
Time:        7.034s
Ran all test suites.

This was referenced Apr 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@possumbilities possumbilities possumbilities approved these changes

@TimidRobot TimidRobot Awaiting requested review from TimidRobot TimidRobot is a code owner automatically assigned from creativecommons/technology

@Shafiya-Heena Shafiya-Heena Awaiting requested review from Shafiya-Heena Shafiya-Heena is a code owner automatically assigned from creativecommons/technology

@kgodey kgodey Awaiting requested review from kgodey kgodey is a code owner automatically assigned from creativecommons/ct-license-chooser-maintainers

Assignees

@Cronus1007 Cronus1007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Cypress to latest
4 participants
@Cronus1007 @TimidRobot @possumbilities @143divya