Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: find rules without test #3881

Open
main
base: main
Choose a base branch
from
Open

chore: find rules without test #3881

main from

Conversation

fzipi
Copy link
Member

Fixes #3880

chore: find rules without test
f851930 
Signed-off-by: Felipe Zipitria <[email protected]>
@theseion
Copy link
Contributor

The issue says that the script is being used in the CI/CD pipeline. Will this PR break the pipeline? Are we moving the script somewhere else?

@airween
Copy link
Contributor

airween commented Oct 21, 2024

Are we moving the script somewhere else?

I don't know about anything. @fzipi wrote somewhere that this task is already implemented in some other linter.

Probably we should move that into a separated repository.

Copy link
Member Author

Yes, we should move this one, or better integrate it with the crs-linter.
It is a very simple script that used the same basis from msc_pyparser.

@airween
Copy link
Contributor

airween commented Oct 21, 2024

Yes, we should move this one, or better integrate it with the crs-linter. It is a very simple script that used the same basis from msc_pyparser.

I'm working on it.

@airween airween self-assigned this Oct 21, 2024
@theseion
Copy link
Contributor

So this PR needs to be amended to make the pipeline work again with the "moved" implementation, right?

Copy link
Member Author

Once we do something about it, yes.

Closed
Open
@github-actions github-actions bot added the Stale label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xhoenix Xhoenix Xhoenix approved these changes

Assignees

@airween airween

Labels
release:refactor Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Look at the find-rules-without-testas it is part of CI/CD tools
4 participants
@theseion @airween @Xhoenix