Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Ability to run AMD64 images on AMR64 servers and a few dependency fixes for remote servers #4421

Draft
wants to merge 22 commits into
base: next
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
743e234
feat: qemu for running AMD images on ARM
peaklabs-dev Nov 27, 2024
614c8ea
feat: Install the correct dependecies and configure Docker correctly.
peaklabs-dev Nov 27, 2024
bb384a2
Merge branch 'next' into fix-amd-on-arm-and-dep
peaklabs-dev Nov 27, 2024
87cde8b
remove unused code
peaklabs-dev Nov 27, 2024
e6019e0
new ValidateServer file with all validation logic in one place
peaklabs-dev Nov 27, 2024
9eda2ee
use the new functions in validate and install
peaklabs-dev Nov 27, 2024
7a8e627
new validate and install UI
peaklabs-dev Nov 27, 2024
9acc26d
install dep like in install script
peaklabs-dev Nov 27, 2024
1039ea0
return clean OS name
peaklabs-dev Nov 27, 2024
a6287fa
use listeners to go through the install
peaklabs-dev Nov 27, 2024
bb203d0
set docker version to install
peaklabs-dev Nov 27, 2024
d4e09bc
Add some error messages to translation
peaklabs-dev Nov 27, 2024
0983947
feat: new validation UI
peaklabs-dev Nov 27, 2024
c8663bb
Merge branch 'next' into fix-amd-on-arm-and-dep
peaklabs-dev Nov 28, 2024
e4a781a
Merge branch 'next' into fix-amd-on-arm-and-dep
peaklabs-dev Dec 2, 2024
a7e3f2b
Merge branch 'coollabsio:main' into fix-amd-on-arm-and-dep
peaklabs-dev Dec 4, 2024
b370864
Merge branch 'next' into fix-amd-on-arm-and-dep
peaklabs-dev Dec 4, 2024
c7114df
Merge branch 'next' into fix-amd-on-arm-and-dep
peaklabs-dev Dec 4, 2024
d9daf5a
Merge branch 'next' into fix-amd-on-arm-and-dep
peaklabs-dev Dec 4, 2024
29918ab
Merge branch 'coollabsio:main' into fix-amd-on-arm-and-dep
peaklabs-dev Dec 5, 2024
a13f952
Merge branch 'next' into fix-amd-on-arm-and-dep
peaklabs-dev Dec 9, 2024
25f5989
Merge branch 'next' into fix-amd-on-arm-and-dep
peaklabs-dev Dec 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
new ValidateServer file with all validation logic in one place
  • Loading branch information
peaklabs-dev committed Nov 27, 2024
commit e6019e0a1e300c3ff0b3b6b84c43215f240d8b70
208 changes: 165 additions & 43 deletions app/Actions/Server/ValidateServer.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,67 +3,189 @@
namespace App\Actions\Server;

use App\Models\Server;
use Lorisleiva\Actions\Concerns\AsAction;
use Exception;

class ValidateServer
{
use AsAction;
public function validateConnection(Server $server, bool $justCheckingNewKey = false): array
{
config()->set('constants.ssh.mux_enabled', false);

try {
instant_remote_process(['ls /'], $server);
if ($server->settings->is_reachable === false) {
$server->settings->is_reachable = true;
$server->settings->save();
}

$server->update(['validation_logs' => null]);

return ['uptime' => true, 'error' => null];
} catch (\Throwable $e) {
if ($justCheckingNewKey) {
return ['uptime' => false, 'error' => __('server.key_not_valid')];
}

if ($server->settings->is_reachable === true) {
$server->settings->is_reachable = false;
$server->settings->save();
}

$errorMessage = __('server.not_reachable').'<br><br><div class="text-error">Error: '.$e->getMessage().'</div>';
$server->update(['validation_logs' => $errorMessage]);

public string $jobQueue = 'high';
return ['uptime' => false, 'error' => $e->getMessage()];
}
}

public function validateOS(Server $server): array
{
try {
$os_release = instant_remote_process(['cat /etc/os-release'], $server);
$releaseLines = collect(explode("\n", $os_release));

$collectedData = $releaseLines->reduce(function ($carry, $line) {
$item = str($line)->trim();
$key = $item->before('=')->value();
$value = $item->after('=')->lower()->replace('"', '')->value();
$carry[$key] = $value;

public ?string $uptime = null;
return $carry;
}, []);

public ?string $error = null;
$ID = data_get($collectedData, 'ID');

public ?string $supported_os_type = null;
$supported = collect(SUPPORTED_OS)
->first(fn ($supportedOs) => str($supportedOs)->contains($ID));

public ?string $docker_installed = null;
if (! $supported) {
$errorMessage = __('server.os_not_supported');
$server->update(['validation_logs' => $errorMessage]);

public ?string $docker_compose_installed = null;
return ['supported' => false, 'error' => $errorMessage];
}

public ?string $docker_version = null;
return ['supported' => true, 'os_type' => str($supported), 'error' => null];
} catch (\Exception $e) {
$errorMessage = __('server.os_check_failed');
$server->update(['validation_logs' => $errorMessage]);

public function handle(Server $server)
return ['supported' => false, 'error' => $errorMessage];
}
}

public function validateDockerEngine(Server $server, bool $throwError = false): array
{
$server->update([
'validation_logs' => null,
]);
['uptime' => $this->uptime, 'error' => $error] = $server->validateConnection();
if (! $this->uptime) {
$this->error = 'Server is not reachable. Please validate your configuration and connection.<br>Check this <a target="_blank" class="text-black underline dark:text-white" href="https://coolify.io/docs/knowledge-base/server/openssh">documentation</a> for further help. <br><br><div class="text-error">Error: '.$error.'</div>';
$server->update([
'validation_logs' => $this->error,
]);
throw new \Exception($this->error);
try {
$dockerBinary = instant_remote_process(['command -v docker'], $server, false, no_sudo: true);
if (is_null($dockerBinary)) {
$server->settings->is_usable = false;
$server->settings->save();

$errorMessage = __('server.docker_not_installed');
$server->update(['validation_logs' => $errorMessage]);

return ['installed' => false, 'error' => $errorMessage];
}

instant_remote_process(['docker version'], $server);

$server->settings->is_usable = true;
$server->settings->save();
$this->validateCoolifyNetwork($server);

return ['installed' => true, 'error' => null];
} catch (\Throwable $e) {
$server->settings->is_usable = false;
$server->settings->save();

$errorMessage = __('server.docker_not_running');
$server->update(['validation_logs' => $errorMessage]);

return ['installed' => false, 'error' => $errorMessage];
}
$this->supported_os_type = $server->validateOS();
if (! $this->supported_os_type) {
$this->error = 'Server OS type is not supported. Please install Docker manually before continuing: <a target="_blank" class="text-black underline dark:text-white" href="https://docs.docker.com/engine/install/#server">documentation</a>.';
$server->update([
'validation_logs' => $this->error,
]);
throw new \Exception($this->error);
}

public function validateDockerCompose(Server $server): array
{
try {
$dockerCompose = instant_remote_process(['docker compose version'], $server, false);
if (is_null($dockerCompose)) {
$server->settings->is_usable = false;
$server->settings->save();

$errorMessage = __('server.docker_compose_not_installed');
$server->update(['validation_logs' => $errorMessage]);

return ['installed' => false, 'error' => $errorMessage];
}

$server->settings->is_usable = true;
$server->settings->save();

return ['installed' => true, 'error' => null];
} catch (\Throwable $e) {
$errorMessage = __('server.docker_compose_check_failed');
$server->update(['validation_logs' => $errorMessage]);

return ['installed' => false, 'error' => $errorMessage];
}
}

public function validateDockerEngineVersion(Server $server): array
{
try {
$dockerVersionRaw = instant_remote_process(['docker version --format json'], $server, false);
$dockerVersionJson = json_decode($dockerVersionRaw, true);
$dockerVersion = data_get($dockerVersionJson, 'Server.Version', '0.0.0');
$dockerVersion = checkMinimumDockerEngineVersion($dockerVersion);

if (is_null($dockerVersion)) {
$server->settings->is_usable = false;
$server->settings->save();

$errorMessage = __('server.docker_engine_not_installed');
$server->update(['validation_logs' => $errorMessage]);

$this->docker_installed = $server->validateDockerEngine();
$this->docker_compose_installed = $server->validateDockerCompose();
if (! $this->docker_installed || ! $this->docker_compose_installed) {
$this->error = 'Docker Engine is not installed. Please install Docker manually before continuing: <a target="_blank" class="text-black underline dark:text-white" href="https://docs.docker.com/engine/install/#server">documentation</a>.';
$server->update([
'validation_logs' => $this->error,
]);
throw new \Exception($this->error);
return ['valid' => false, 'error' => $errorMessage];
}

$server->settings->is_reachable = true;
$server->settings->is_usable = true;
$server->settings->save();

return ['valid' => true, 'error' => null];
} catch (\Throwable $e) {
$errorMessage = __('server.docker_version_check_failed');
$server->update(['validation_logs' => $errorMessage]);

return ['valid' => false, 'error' => $errorMessage];
}
$this->docker_version = $server->validateDockerEngineVersion();
}

if ($this->docker_version) {
return 'OK';
public function validateCoolifyNetwork(Server $server, bool $isSwarm = false, bool $isBuildServer = false): ?bool
{
if ($isBuildServer) {
return null;
}
if ($isSwarm) {
return instant_remote_process(['docker network create --attachable --driver overlay coolify-overlay >/dev/null 2>&1 || true'], $server, false);
} else {
$this->error = 'Docker Engine is not installed. Please install Docker manually before continuing: <a target="_blank" class="text-black underline dark:text-white" href="https://docs.docker.com/engine/install/#server">documentation</a>.';
$server->update([
'validation_logs' => $this->error,
]);
throw new \Exception($this->error);
return instant_remote_process(['docker network create coolify --attachable >/dev/null 2>&1 || true'], $server, false);
}
}

public function validateDockerSwarm(Server $server): bool
{
$swarmStatus = instant_remote_process(['docker info|grep -i swarm'], $server, false);
$swarmStatus = str($swarmStatus)->trim()->after(':')->trim();
if ($swarmStatus === 'inactive') {
throw new Exception(__('server.swarm_not_initiated'));
}
$server->settings->is_usable = true;
$server->settings->save();
$this->validateCoolifyNetwork($server, isSwarm: true);

return true;
}
}