fix: always use container interface #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
==========================================
- Coverage 66.98% 66.75% -0.24%
==========================================
Files 25 25
Lines 2311 2319 +8
==========================================
Hits 1548 1548
- Misses 667 675 +8
Partials 96 96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all "public" usage of
container.Container(the impl struct) withtypes.Container(the interface). It also renames theContainer.hostConfig()andContainer.runtimeConfig()toGetCreateHostConfig()andGetCreateConfigrespectively, to more clearly express what they are used for.While working on fixing the tests/API changes for #1468, I noticed how hard it was to work with the
container.Container, since it was sometimes passed as an interface, and sometimes the raw struct.This made creating sensible new APIs really hard and is the one of the main reasons for a lot of the problems with testing using
Containers.Since this was a fairly large change, I moved these changes to a new branch.