Update vendor containers/(common,image) #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel J Walsh <[email protected]>
mtrmac
reviewed
Sep 30, 2022
| @@ -245,12 +245,12 @@ test-unit-local: bin/skopeo | |||
| $(GO) test $(MOD_VENDOR) -tags "$(BUILDTAGS)" $$($(GO) list $(MOD_VENDOR) -tags "$(BUILDTAGS)" -e ./... | grep -v '^github\.com/containers/skopeo/\(integration\|vendor/.*\)$$') | |||
|
|
|||
| vendor: | |||
| $(GO) mod tidy | |||
| $(GO) mod tidy -compat=1.17 | |||
There was a problem hiding this comment.
I’m not too happy with this; it’s going to stay around forgotten forever.
AFAICT the typical effect of keeping compatibility with 1.16 is
- to have to copy&paste a command from an error message, and run it — sure, a hassle
- to end up with newer versions of some dependencies — a good thing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel J Walsh [email protected]