Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config files live in /usr/local/etc on FreeBSD (highlight in release notes!) #1642

Merged
merged 2 commits into from
May 10, 2022

Conversation

dfr
Copy link
Contributor

@dfr dfr commented May 10, 2022

Config files for non-base packages live in /usr/local/etc and containers/image#1544 changes the default paths in containers/image. This changes the skopeo Makefile to match.

dfr added 2 commits May 10, 2022 10:37
On FreeBSD, bash lives in /usr/local/bin/bash. These scripts don't
really depend on bash so could be changed to /bin/sh.

Signed-off-by: Doug Rabson <[email protected]>
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

@mtrmac mtrmac changed the title Config files live in /usr/local/etc on FreeBSD Config files live in /usr/local/etc on FreeBSD (highlight in release notes!) May 10, 2022
@rhatdan
Copy link
Member

rhatdan commented May 10, 2022

LGTM

@rhatdan rhatdan merged commit a90efa2 into containers:main May 10, 2022
@mtrmac
Copy link
Contributor

mtrmac commented May 10, 2022

NOTE: This will only work if we vendor an updated c/image before a Skopeo release. Historically that’s consistently been the practice, just making a note here for posterity if something went wrong.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants